Kismet Wireless

Kismet Forums

 

Posted by:iluxa
Subject:As promised, Unix-domain socket support
Date:19:16:27 14/12/2009

> > Oops. Correct one is http://www.total-knowledge.com/progs/kismet/unix-domain-server.diff
> >
> >
> > > > This patch adds support for unix-domain socket server.
> > > >
> > > > I tested it with my own plugin - it works so far.
> > >
> > > wrong link.
> > >
> > > -m
>
> Merged, with some changes -
>
> - trying to use spaces not tabs everywhere, :retab'd and fixed > 80char lines
Yes, the code is littered with mixture all over the place.
Perhaps the whole thing should be run through a script to
unify indentation.

I'd suggest using tabs though - this way people reading the code
can adjust indentation size to their comfort level.

> - switched default ringbuf size define to UNIX_... to prevent collisions in anything including both tcp and unix headers
> - threw in a warning in comments about using this in a root binary that could ever accept the socket path from non-root input, since it calls unlink()
> - switched all the error reporting to direct _MSG calls (yeah, not your fault, I know the tcp server code uses errstr and inject instead of the MSG macro, it's older code.)


I just checked - still works just fine with my plugin :)

Ilya.


Reply to this message